Improve wallet show output.
#4927
Merged
+38
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afck
requested review from
MathieuDutSik,
Twey,
bart-linera,
deuszx,
eldios,
ma2bd and
ndr-ds
ma2bd
approved these changes
Nov 6, 2025
| Some(ChainOrigin::Root(i)) => format!("Root Chain {i}"), | ||
| _ => "Child Chain".to_string(), | ||
| println!("-----------------------"); | ||
| println!(" {:<20} {}", "Chain ID:", self.user_chain.chain_id); |
Contributor
There was a problem hiding this comment.
We could almost remove the indentation if we wanted now
Contributor
Author
There was a problem hiding this comment.
Do you prefer that?
Do you mean remove the two leading spaces, or remove the alignment of the values?
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Nov 7, 2025
This is the result after a few discussions about what `wallet show`
should look like.
Add separators between the chains. Format everything in a "Key: Value"
style.
Sample output:
```
2025-11-06T16:46:41.842672Z INFO linera: Reading wallet from file: /tmp/.tmp6RClv1/wallet_0.json
2025-11-06T16:46:41.843635Z INFO linera_service::wallet: Found 4 chains
-----------------------
Chain ID: 7471c597d573ef4d53934b9fcc6a05b9d46cb3718244d01ff817234ac2ae8c28
Tags: DEFAULT, ADMIN
Parent chain: -
Default owner: 0x227d131b5f2e3987daf184f2d22af7e7e0f174d2baca1228a45f12be11e80a5c
Timestamp: 2025-11-06 16:46:37.399799
Blocks: 1
Epoch: 0
Latest block hash: 718814dae46334008efb769d5c24521c879cd756bb600c2bb56b09c1609d4c52
-----------------------
Chain ID: 5d719d9ace5441bdd4e4f7469fb3335445813935fdc2acc0dff60162642f2787
Parent chain: -
Default owner: 0x929139f3c9b52dac48795038b7427aa5d07333718f74de7ea21c40fc28c11ae6
Timestamp: 2025-11-06 16:46:22.179469
Blocks: 0
Epoch: 0
-----------------------
```
- These changes should be backported to `testnet_conway`, then
- be released in a new SDK.
- Previous `wallet show` change:
linera-io#4642
- [reviewer
checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
ma2bd
pushed a commit
that referenced
this pull request
Nov 7, 2025
This is the result after a few discussions about what `wallet show`
should look like.
Add separators between the chains. Format everything in a "Key: Value"
style.
Sample output:
```
2025-11-06T16:46:41.842672Z INFO linera: Reading wallet from file: /tmp/.tmp6RClv1/wallet_0.json
2025-11-06T16:46:41.843635Z INFO linera_service::wallet: Found 4 chains
-----------------------
Chain ID: 7471c597d573ef4d53934b9fcc6a05b9d46cb3718244d01ff817234ac2ae8c28
Tags: DEFAULT, ADMIN
Parent chain: -
Default owner: 0x227d131b5f2e3987daf184f2d22af7e7e0f174d2baca1228a45f12be11e80a5c
Timestamp: 2025-11-06 16:46:37.399799
Blocks: 1
Epoch: 0
Latest block hash: 718814dae46334008efb769d5c24521c879cd756bb600c2bb56b09c1609d4c52
-----------------------
Chain ID: 5d719d9ace5441bdd4e4f7469fb3335445813935fdc2acc0dff60162642f2787
Parent chain: -
Default owner: 0x929139f3c9b52dac48795038b7427aa5d07333718f74de7ea21c40fc28c11ae6
Timestamp: 2025-11-06 16:46:22.179469
Blocks: 0
Epoch: 0
-----------------------
```
- These changes should be backported to `testnet_conway`, then
- be released in a new SDK.
- Previous `wallet show` change:
#4642
- [reviewer
checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the result after a few discussions about what
wallet showshould look like.Proposal
Add separators between the chains. Format everything in a "Key: Value" style.
Test Plan
Sample output:
Release Plan
testnet_conway, thenLinks
wallet showchange: Improvewallet show. #4642